-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style: Mark equations where black formatting should not apply #122
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #122 +/- ##
==========================================
+ Coverage 88.74% 88.83% +0.09%
==========================================
Files 36 36
Lines 1901 1917 +16
==========================================
+ Hits 1687 1703 +16
Misses 214 214 ☔ View full report in Codecov by Sentry. |
Let's wait until #124 is merged to merge this one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've flagged 3 equations which I think are too long and deserve to be simplified in the code. The rest looks good to me.
Black formatting is intended for OOP python, not mathematical expressions. Often the way it breaks up an equation makes it harder to read. Here we mark equations that shouldn't be formatted by Black.